how to do this question

Question

i cant seem to figure this out

creating_getters.js

class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }
    get level(){
      const credits = this.credits;
      if(credits > 90){
        return 'Senior';
      } 
      else if (credits < 90 && credits >= 61){
        return 'Junior';
      }
      else if (credits < 60 && credits >= 31){
        return 'Sophomore';
      }
      else if (credits < 30){
        return 'Freshman';
      }
    }

    stringGPA() {
        return this.gpa.toString();
    }
}

const student = new Student(3.9, 50);

Answer 1 · 2022-11-05T12:28:14Z

November 5, 2022 12:28pm

Hi Nima. You are super close. Let me ask you. What happens if a student has 90, 60 or 30 credits? You are checking for > 90 and < 90 but never 90. A quick and dirty fix to pass the challenge is to change the conditions to credits <= like this:

else if (credits <=90 && credits >= 61){
        return 'Junior';
      }
      else if (credits <= 60 && credits >= 31){
        return 'Sophomore';
      }
      else if (credits <= 30){

BUT

Do we even need those conditions?

If a student has more than 90 credits they are a senior. So do we need to check if a student has <= 90 credits when we are checking for a junior? No. Because if they had more that 90 they would be a senior. So when we get to the first else we know the student has less or equal 90 credits. We only need to check if credits >= 61 because that makes them a junior.

Same for Sophomores. We know they have <= 60 credits or they would be a junior or senior.

Then for Freshman you don't need any condition. That can just be an else because if they are not a senior, junior or sophomore then they have to be a freshman

Hope this helps and be sure to post back to the community if you are still stuck.

Welcome to the Treehouse Community

Looking to learn something new?

Nima Sakha

Nima Sakha

how to do this question

1 Answer

Mark Sebeck

Mark Sebeck