What's wrong with my code?

Question

Not sure where I'm going wrong. Help?

bank_account.rb

class BankAccount
  attr_reader :name

  def initialize(name)
    @name = name
    @transactions = []
    add_transaction("Beginning Balance", 0)
  end

  def debit(description, amount)
    add_transaction(description, -amount)
  end

  def credit(description, amount)
    add_transaction(description, amount)
  end

  def add_transaction(description, amount)
    @transactions.push(description: description, amount: amount)
  end

  def balance
    balance = 0
    @transactions.each do |debit|
      balance += debit[:amount]
    end
    @transactions.each do |credit|
      balance += credit[:amount]
    end
  end

end

Answer 1 · 2016-01-19T01:50:26Z

January 19, 2016 1:50am

you don't need to loop through twice - since credit is already going to subtract and debit is going to add. So once is enough to get the job done.

Another thing you forgot to return balance once the loop is finished.

Welcome to the Treehouse Community

Looking to learn something new?

Patrick Mockridge

Patrick Mockridge

What's wrong with my code?

1 Answer

Steve Chen

Steve Chen